Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_s3: fix wrong decrementing of INDEX when UploadPart fails #7394

Merged

Conversation

PettitWesley
Copy link
Contributor


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@PettitWesley PettitWesley temporarily deployed to pr May 16, 2023 04:27 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 16, 2023 04:27 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 16, 2023 04:27 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 16, 2023 04:50 — with GitHub Actions Inactive
@PettitWesley PettitWesley force-pushed the index_s3_key_format_decrement_fix_2.0 branch from 8528f7b to 965b440 Compare June 14, 2023 23:17
@PettitWesley PettitWesley temporarily deployed to pr June 14, 2023 23:18 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr June 14, 2023 23:18 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr June 14, 2023 23:18 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr June 14, 2023 23:40 — with GitHub Actions Inactive
@edsiper edsiper added this to the Fluent Bit v2.1.5 milestone Jun 14, 2023
@edsiper edsiper merged commit bc5bbe7 into fluent:2.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants